Please Support "make install"

Ideas & suggestions
1

I am currently creating a “spack” package recipe for MolfflowCLI.

Compiling works fine, just the final “make install”

…
[100%] Built target molflowCLI
==> molflow: Executing phase: 'install'
==> [2022-03-31-14:53:20.162800] 'make' '-j8' 'install'
make: *** No rule to make target 'install'.  Stop.

Could you consider adding install support to the CMake system?

Interesting links:

Thanks for looking into this!

2

That’s a great suggestion.
I’ll try to include it for the upcoming 2.9.4 release which is planned for one of the following weeks.

Cheers,
Pascal

3

This feature has been added with the newest release.
Please let me know if there are problems concerning the new install method!
Find the download and changelog on our gitlab release page for 2.9.4:

A rough description on how to use it, can be found in the repository’s README.md:
molflow_synrad / molflow · GitLab (see CMake / make installation)

4

Molflow 2.9.4 beta was installed via spack on our HPC Slurm cluster. Here’s a comment from Dmytro Kresan / IT department:

molflow was updated to 2.9.4_beta on both centos7 and debian10 VAEs. Usage:

spack load molflow@2.9.4_beta target=x86_64

Native cmake install is still broken, we applied our fix also to this version.

MPI support seems to be experimental. After many tries to enable it, molflow was not able to find OpenMPI installation. It is disabled in the current installation. Please consider contacting developers.

5

Hey Ivan!
Could you share some more details about
a) which version of OpenMPI you are using
b) what exactly is not working with cmake install (saying it is still broken)
c) How are you trying to “enable” MPI?

Molflow needs to be build with the cmake flag USE_MPI set (Check README / Building for MPI). It is then CMake that is trying to locate and verify the MPI installation. It would be nice to get more details concerning your installation and setup routine and possible error messages you are seeing.
It is important for us to understand, where other teams are running into problems with the usage of the new MPI powered application.

Best regards,
Pascal

6

Thanks for the hint with USE_MPI. Now it is working and we can properly link with OpenMPI 3.1. Beforehand, I was using MPI_HOME variable with the exact location, but that was not used even.

Concerning make install: we are missing the following file:
$CMAKE_INSTALL_PREFIX/bin/molflowCLI

Would that be possible to add it?

Best regards,
Dima